Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YAML validation contribution point #2122

Merged
merged 2 commits into from
May 8, 2023
Merged

Conversation

bwateratmsft
Copy link
Contributor

@bwateratmsft bwateratmsft commented May 8, 2023

RedHat's YAML extension has a way to specify a contribution point that will map certain file name patterns to a given schema. The comment (e.g. this) at the top of our azure.yaml files does this already, but for user-provided or user-modified azure.yaml files where that comment is gone, this adds an extra layer of association between azure.yaml and its schema.

microsoft/compose-language-service#122 is vaguely related--mostly in that I'm the one working on that too--but having the Docker extension deconflicted with the YAML extension is in this extension's best interest as well.

@ghost ghost assigned bwateratmsft May 8, 2023
@bwateratmsft bwateratmsft enabled auto-merge (squash) May 8, 2023 17:23
@azure-sdk
Copy link
Collaborator

VSCode Extension Installation Instructions

  1. Download the extension at https://azuresdkreleasepreview.blob.core.windows.net/azd/vscode/pr/2122/azure-dev-0.6.0-alpha.1.vsix
  2. Extract the extension from the compressed file
  3. In vscode
    a. Open "Extensions" (Ctrl+Shift+X)
    b. Click the ...\ menu at top of Extensions sidebar
    c. Click "Install from VSIX"
    d. Select location of downloaded file

Copy link
Member

@ellismg ellismg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Very cool we can do this!

ext/vscode/.vscode/settings.json Show resolved Hide resolved
@bwateratmsft bwateratmsft merged commit eae93ce into main May 8, 2023
11 checks passed
@bwateratmsft bwateratmsft deleted the bmw/yamlValidation2 branch May 8, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants