Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add document drop handler and telemetry #2448

Merged
merged 35 commits into from Jul 11, 2023
Merged

Add document drop handler and telemetry #2448

merged 35 commits into from Jul 11, 2023

Conversation

bwateratmsft
Copy link
Contributor

@bwateratmsft bwateratmsft commented Jun 21, 2023

Related to #1389, adds a special new feature just for @savannahostrowski and @gkulin. Drag a folder into azure.yaml and hold Shift before releasing--it will automatically add a service to your azure.yaml file, with tab stops at the project language and host and enums to help select the right values in those places.

DocumentDropProvider

This feature is admittedly pretty gimmicky but I thought it looked neat.

Base automatically changed from bmw/rename to main June 21, 2023 19:48
@bwateratmsft bwateratmsft enabled auto-merge (squash) June 22, 2023 12:53
@karolz-ms
Copy link
Contributor

The code looks great, but I have doubts about the cost/risk/benefit tradeoff of this change.

Discoverability of the feature is terrible. Utility is marginal at best given that azure.yaml already has a good schema/syntax hinting, and that the initial output often needs tweaking. Not a lot of code admittingly, but is the overall user benefit high enough to offset the cost of testing and maintenance?

@savannahostrowski
Copy link
Contributor

I'm playing catch up now that I'm back from vacation. Oh this is super cool! I think that this will definitely be helpful to some folks who really struggle with paths. I don't disagree with Karol re. discoverability but tbh, there are loads of valuable features in VS Code with poor discoverability (basically all VS Code settings 🙂)

Can we instrument telemetry around this so we can monitor how often it's being used/triggered?

@bwateratmsft
Copy link
Contributor Author

Discoverability of the feature is terrible.

Absolutely agreed. Especially since you have to hold Shift to even get the options to show when dropping. Not a common paradigm at all.

Utility is marginal at best given that azure.yaml already has a good schema/syntax hinting, and that the initial output often needs tweaking. Not a lot of code admittingly, but is the overall user benefit high enough to offset the cost of testing and maintenance?

I thought of this more as a fun feature to show off in demos than to actually be seriously useful to end users. If it starts presenting itself as a maintenance problem, I wouldn't hesitate to drop it.

@bwateratmsft
Copy link
Contributor Author

Can we instrument telemetry around this so we can monitor how often it's being used/triggered?

Yes, and in fact I think I'll add some additional telemetry on the other language features as well.

@savannahostrowski
Copy link
Contributor

I thought of this more as a fun feature to show off in demos than to actually be seriously useful to end users. If it starts presenting itself as a maintenance problem, I wouldn't hesitate to drop it.

Yeah - makes sense to me. With telemetry, we can see if it's really a useful feature for folks to have/worth the maintenance.

@azure-sdk
Copy link
Collaborator

VSCode Extension Installation Instructions

  1. Download the extension at https://azuresdkreleasepreview.blob.core.windows.net/azd/vscode/pr/2448/azure-dev-0.7.0-alpha.1.vsix
  2. Extract the extension from the compressed file
  3. In vscode
    a. Open "Extensions" (Ctrl+Shift+X)
    b. Click the ...\ menu at top of Extensions sidebar
    c. Click "Install from VSIX"
    d. Select location of downloaded file

@bwateratmsft bwateratmsft changed the title Add document drop handler Add document drop handler and telemetry Jul 11, 2023
@savannahostrowski
Copy link
Contributor

@esweet431 as FYI for new feature + telemetry

@bwateratmsft bwateratmsft merged commit 579c37e into main Jul 11, 2023
12 checks passed
@bwateratmsft bwateratmsft deleted the bmw/lang branch July 11, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants