Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GHA to templates #2462

Merged
merged 11 commits into from Jul 17, 2023
Merged

add GHA to templates #2462

merged 11 commits into from Jul 17, 2023

Conversation

hemarina
Copy link
Contributor

@hemarina hemarina commented Jun 27, 2023

fix: #1776, #2205 and #2206
All templates are updated except for java-postgre-terraform. This template is not included in our pipeline run and it is still private.

@ghost ghost assigned hemarina Jun 27, 2023
@hemarina hemarina changed the title add GHA to templates WIP: add GHA to templates Jun 27, 2023
@savannahostrowski
Copy link
Contributor

This should close #2205 and #2206, right?

@hemarina hemarina changed the title WIP: add GHA to templates add GHA to templates Jul 13, 2023
@hemarina hemarina marked this pull request as ready for review July 13, 2023 18:19
@hemarina hemarina requested a review from wbreza as a code owner July 13, 2023 18:19
Copy link
Contributor

@wbreza wbreza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the testing strategy to ensure CI/CD is working for all our templates?

@vhvb1989
Copy link
Member

What is the testing strategy to ensure CI/CD is working for all our templates?

automating azd pipeline config is still WIP. see: #1783

Right now, the strategy is by running manual tests

@hemarina
Copy link
Contributor Author

hemarina commented Jul 13, 2023

Manual test ran all templates on azd pipeline config and they are passed except for Java-postgresql-terraform.

Java-postgresql-terraform related issue #2478 will be discussed on our choice for this template in #2498

Issues are closed because it is solved or because we are supporting linux os using the same pattern.
#2472, #2473, #2475, #2476, #2477.

@hemarina hemarina requested a review from weikanglim July 13, 2023 21:49
@azure-sdk
Copy link
Collaborator

Repoman Generation Results

Repoman pushed changes to remotes for the following projects:

Project: azd-starter-bicep

Remote: azure-samples-staging

Branch: pr/2462

You can initialize this project with:

azd init -t Azure-Samples/azd-starter-bicep -b pr/2462

View Changes | Compare Changes


Project: azd-starter-terraform

Remote: azure-samples-staging

Branch: pr/2462

You can initialize this project with:

azd init -t Azure-Samples/azd-starter-terraform -b pr/2462

View Changes | Compare Changes


Project: todo-csharp-cosmos-sql

Remote: azure-samples-staging

Branch: pr/2462

You can initialize this project with:

azd init -t Azure-Samples/todo-csharp-cosmos-sql -b pr/2462

View Changes | Compare Changes


Project: todo-csharp-sql-swa-func

Remote: azure-samples-staging

Branch: pr/2462

You can initialize this project with:

azd init -t Azure-Samples/todo-csharp-sql-swa-func -b pr/2462

View Changes | Compare Changes


Project: todo-csharp-sql

Remote: azure-samples-staging

Branch: pr/2462

You can initialize this project with:

azd init -t Azure-Samples/todo-csharp-sql -b pr/2462

View Changes | Compare Changes


Project: todo-java-mongo-aca

Remote: azure-samples-staging

Branch: pr/2462

You can initialize this project with:

azd init -t Azure-Samples/todo-java-mongo-aca -b pr/2462

View Changes | Compare Changes


Project: todo-java-mongo

Remote: azure-samples-staging

Branch: pr/2462

You can initialize this project with:

azd init -t Azure-Samples/todo-java-mongo -b pr/2462

View Changes | Compare Changes


Project: todo-nodejs-mongo-aca

Remote: azure-samples-staging

Branch: pr/2462

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo-aca -b pr/2462

View Changes | Compare Changes


Project: todo-nodejs-mongo-aks

Remote: azure-samples-staging

Branch: pr/2462

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo-aks -b pr/2462

View Changes | Compare Changes


Project: todo-nodejs-mongo-swa-func

Remote: azure-samples-staging

Branch: pr/2462

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo-swa-func -b pr/2462

View Changes | Compare Changes


Project: todo-nodejs-mongo

Remote: azure-samples-staging

Branch: pr/2462

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo -b pr/2462

View Changes | Compare Changes


Project: todo-nodejs-mongo-terraform

Remote: azure-samples-staging

Branch: pr/2462

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo-terraform -b pr/2462

View Changes | Compare Changes


Project: todo-python-mongo-aca

Remote: azure-samples-staging

Branch: pr/2462

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo-aca -b pr/2462

View Changes | Compare Changes


Project: todo-python-mongo-swa-func

Remote: azure-samples-staging

Branch: pr/2462

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo-swa-func -b pr/2462

View Changes | Compare Changes


Project: todo-python-mongo

Remote: azure-samples-staging

Branch: pr/2462

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo -b pr/2462

View Changes | Compare Changes


Project: todo-python-mongo-terraform

Remote: azure-samples-staging

Branch: pr/2462

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo-terraform -b pr/2462

View Changes | Compare Changes


@hemarina hemarina merged commit 967d8eb into Azure:main Jul 17, 2023
24 checks passed
@hemarina hemarina deleted the setup-azd branch April 11, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Templates][Devcontainers] docker build cache would prevent installing latest azd version on containers.
7 participants