Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating all templates to use the devconatiner feature #2489

Merged
merged 10 commits into from Jul 13, 2023
Merged

Updating all templates to use the devconatiner feature #2489

merged 10 commits into from Jul 13, 2023

Conversation

aaronpowell
Copy link
Contributor

@aaronpowell aaronpowell commented Jul 6, 2023 •
edited by hemarina

With #1118 merged, this PR updates all the templates except (swa templates and todo-java-postgresql-terraform) use the feature rather than installing the azd cli within the Dockerfile.

This PR is pending the publishing of the feature to the agreed container registry.

Closes #2490

wbreza
wbreza reviewed Jul 10, 2023
View reviewed changes
Copy link
Contributor

@wbreza wbreza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about using stable as default version instead of latest. I would also expect that version is not required and by default it would use the latest stable release of azd.

templates/common/.devcontainer/devcontainer.json/aks/nodejs/devcontainer.json Outdated Show resolved Hide resolved
@aaronpowell aaronpowell force-pushed the aaronpowell/devcontainer-feature-usage branch from d194c97 to 8907989 Compare July 10, 2023 23:56
@hemarina hemarina marked this pull request as ready for review July 11, 2023 19:42
@hemarina hemarina requested a review from karolz-ms as a code owner July 11, 2023 19:42
@ellismg
Copy link
Member

ellismg commented Jul 11, 2023

/azp run azure-dev - repoman

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ellismg
Copy link
Member

ellismg commented Jul 11, 2023

Looks like there are some issues with the PR that are getting caught by repoman now, @hemarina (https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2910196&view=logs&j=dc5beac1-197e-530f-c839-b08cb3c610f0&t=0cca624c-13bf-5c9a-9485-f7429792da43).

I think that these jobs might not auto-fire because Aaron opened the PR. You can manually run them using the /azp command as I did above.

@hemarina

This comment was marked as duplicate.

Sign in to view
@azure-pipelines

This comment was marked as duplicate.

Sign in to view
@hemarina

This comment was marked as duplicate.

Sign in to view
@azure-pipelines

This comment was marked as resolved.

Sign in to view
@hemarina

This comment was marked as duplicate.

Sign in to view
@azure-pipelines

This comment was marked as duplicate.

Sign in to view
@hemarina

This comment was marked as duplicate.

Sign in to view
@azure-pipelines

This comment was marked as duplicate.

Sign in to view
@azure-sdk
Copy link
Collaborator

Repoman Generation Results

Repoman pushed changes to remotes for the following projects:

Project: azd-starter-bicep

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/azd-starter-bicep -b pr/2489

View Changes | Compare Changes

Project: azd-starter-terraform

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/azd-starter-terraform -b pr/2489

View Changes | Compare Changes

Project: todo-csharp-cosmos-sql

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/todo-csharp-cosmos-sql -b pr/2489

View Changes | Compare Changes

Project: todo-csharp-sql-swa-func

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/todo-csharp-sql-swa-func -b pr/2489

View Changes | Compare Changes

Project: todo-csharp-sql

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/todo-csharp-sql -b pr/2489

View Changes | Compare Changes

Project: todo-java-mongo-aca

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/todo-java-mongo-aca -b pr/2489

View Changes | Compare Changes

Project: todo-java-mongo

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/todo-java-mongo -b pr/2489

View Changes | Compare Changes

Project: todo-java-postgresql-terraform

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/todo-java-postgresql-terraform -b pr/2489

View Changes | Compare Changes

Project: todo-nodejs-mongo-aca

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo-aca -b pr/2489

View Changes | Compare Changes

Project: todo-nodejs-mongo-aks

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo-aks -b pr/2489

View Changes | Compare Changes

Project: todo-nodejs-mongo-swa-func

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo-swa-func -b pr/2489

View Changes | Compare Changes

Project: todo-nodejs-mongo

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo -b pr/2489

View Changes | Compare Changes

Project: todo-nodejs-mongo-terraform

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo-terraform -b pr/2489

View Changes | Compare Changes

Project: todo-python-mongo-aca

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo-aca -b pr/2489

View Changes | Compare Changes

Project: todo-python-mongo-swa-func

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo-swa-func -b pr/2489

View Changes | Compare Changes

Project: todo-python-mongo

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo -b pr/2489

View Changes | Compare Changes

Project: todo-python-mongo-terraform

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo-terraform -b pr/2489

View Changes | Compare Changes

@hemarina hemarina mentioned this pull request Jul 13, 2023
Closed
@hemarina hemarina merged commit a68263d into Azure:main Jul 13, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jongio jongio jongio left review comments

@wbreza wbreza wbreza left review comments

@ellismg ellismg ellismg left review comments

@hemarina hemarina hemarina left review comments

@vhvb1989 vhvb1989 vhvb1989 approved these changes

@karolz-ms karolz-ms Awaiting requested review from karolz-ms karolz-ms is a code owner

Assignees

@aaronpowell aaronpowell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update templates to use azd devcontainer feature
7 participants
@aaronpowell @ellismg @hemarina @azure-sdk @jongio @wbreza @vhvb1989