Update appservice.bicep with gunicorn config #2571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this change in the search-openai sample: |
weikanglim
reviewed
Jul 27, 2023
Co-authored-by: Wei Lim <weikanglim@gmail.com>
weikanglim
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets PYTHON_ENABLE_GUNICORN_MULTIWORKERS by default on App Service, when python runtime is chosen. When Oryx sees that env variable, it will auto configure the gunicorn server to use a worker count based off the formula of CPU_COUNT * 2 + 1. That's generally better than always using a single worker.
Here's Oryx docs about the config option:
https://github.com/microsoft/Oryx/blob/5239b0416cdddcf5bf0aef6703eb339efa865d67/doc/runtimes/python.md?plain=1#L101
The only reason this isn't default on App Service is for backwards compatibility reasons, but I think it should be default for all our App Service Python apps that dont specify their own appCommandLine.