chore: update Node.js to version 18 - #2753
Conversation
microsoft-github-policy-service
Bot
added
the
customer-reported
|
Thank you for your contribution lechnerc77! We will review the pull request and get back to you soon. |
Matt Ellis (ellismg)
left a comment
Matt Ellis (ellismg)
left a comment
There was a problem hiding this comment.
LGTM - thanks for the fix, Christian Lechner (@lechnerc77)!
|
/azp run azure-dev - repoman |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Repoman Generation ResultsRepoman pushed changes to remotes for the following projects: Project: azd-starter-terraformRemote: azure-samples-stagingBranch: pr/2753You can initialize this project with: azd init -t Azure-Samples/azd-starter-terraform -b pr/2753View Changes | Compare Changes Project: todo-csharp-cosmos-sqlRemote: azure-samples-stagingBranch: pr/2753You can initialize this project with: azd init -t Azure-Samples/todo-csharp-cosmos-sql -b pr/2753View Changes | Compare Changes Project: todo-csharp-sql-swa-funcRemote: azure-samples-stagingBranch: pr/2753You can initialize this project with: azd init -t Azure-Samples/todo-csharp-sql-swa-func -b pr/2753View Changes | Compare Changes Project: todo-csharp-sqlRemote: azure-samples-stagingBranch: pr/2753You can initialize this project with: azd init -t Azure-Samples/todo-csharp-sql -b pr/2753View Changes | Compare Changes Project: todo-java-mongo-acaRemote: azure-samples-stagingBranch: pr/2753You can initialize this project with: azd init -t Azure-Samples/todo-java-mongo-aca -b pr/2753View Changes | Compare Changes Project: todo-java-mongoRemote: azure-samples-stagingBranch: pr/2753You can initialize this project with: azd init -t Azure-Samples/todo-java-mongo -b pr/2753View Changes | Compare Changes Project: todo-java-postgresql-terraformRemote: azure-samples-stagingBranch: pr/2753You can initialize this project with: azd init -t Azure-Samples/todo-java-postgresql-terraform -b pr/2753View Changes | Compare Changes Project: todo-nodejs-mongo-acaRemote: azure-samples-stagingBranch: pr/2753You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-aca -b pr/2753View Changes | Compare Changes Project: todo-nodejs-mongo-aksRemote: azure-samples-stagingBranch: pr/2753You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-aks -b pr/2753View Changes | Compare Changes Project: todo-nodejs-mongo-swa-funcRemote: azure-samples-stagingBranch: pr/2753You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-swa-func -b pr/2753View Changes | Compare Changes Project: todo-nodejs-mongoRemote: azure-samples-stagingBranch: pr/2753You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo -b pr/2753View Changes | Compare Changes Project: todo-nodejs-mongo-terraformRemote: azure-samples-stagingBranch: pr/2753You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-terraform -b pr/2753View Changes | Compare Changes Project: todo-python-mongo-acaRemote: azure-samples-stagingBranch: pr/2753You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo-aca -b pr/2753View Changes | Compare Changes Project: todo-python-mongo-swa-funcRemote: azure-samples-stagingBranch: pr/2753You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo-swa-func -b pr/2753View Changes | Compare Changes Project: todo-python-mongoRemote: azure-samples-stagingBranch: pr/2753You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo -b pr/2753View Changes | Compare Changes Project: todo-python-mongo-terraformRemote: azure-samples-stagingBranch: pr/2753You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo-terraform -b pr/2753View Changes | Compare Changes |
4 participants
The current Node.js based templates are building on Node.js 16. This version has reached its end of life on 2023-09-11 (https://nodejs.dev/en/about/releases/). There are aslo some inconsistencies as the App service ToDo app already ran on Node.js 18
This PR contains the update of the files using the outdated Node.js version to the current LTS version Node.js 18.
Remark
I tested the dev conatiner setup the build of the Docker Image and the fucntional correctness of the App service app after the update including a full deploy. However I might have missed some sceanrios and cases, so I assume there is a build pipeline that could be run to check that the overall setup is still healthy.