New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Display the Subscription Name and ID (azd provision) #2829
Conversation
Thank you for your contribution john0isaac! We will review the pull request and get back to you soon. |
I applied all the requested changes except for this one which is handling the error. I think all is done except for displaying the resource group and it surely doesn't appear in all the states so, I will work on it in another pull request as I couldn't directly find it from the env vars. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments.
LGTM!!
Thank you!!
Co-authored-by: Victor Vazquez <victor.vazquez@microsoft.com>
@vhvb1989 done. ✅ Thank you so much! |
@jongio done ✅! |
/azp run azure-dev cli |
No pipelines are associated with this pull request. |
/azp run azure-dev - cli |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSIContainer
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
Closes #2544
I could only get the subscription ID from the environment which is not very useful.
That's why I had to import the account and use the Subscriptions Service from it to get the Subscription Display Name using it's ID.
I didn't use the Subscription Manager as it checks for the tenant before getting the name which is not necessary as we already have the tenant ID and don't need it.
Check out the screenshot below with the new output of azd up and azd provision