Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merge for 1.5.1] Update azure.yaml.json so support docker build target #3057

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

Petermarcu
Copy link
Member

Updating azure.yaml schema to support docker build target

Updating azure.yaml schema to support docker build target
@Petermarcu
Copy link
Member Author

@wbreza

Copy link
Contributor

@wbreza wbreza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We should hold off merging this in till right before next release since we still don't have a good versioning story for our yaml schema. Our schema endpoints in the auzre.yaml point directly to the main branch raw JSON file.

@Petermarcu
Copy link
Member Author

@danieljurek do we know why the check enforcer check is stuck here?

@ellismg
Copy link
Member

ellismg commented Dec 4, 2023

@danieljurek do we know why the check enforcer check is stuck here?

It's "stuck" because we have no jobs that are triggered off of these files (since we don't have any CI legs that validate them) so it is just waiting for some jobs to show up and pass, which will never happen.

/check-enforcer override

Per, @wbreza's comment, we should merge then on 12/12 when we cut 1.5.1.

@Petermarcu
Copy link
Member Author

Ok, I'll let you hang onto this and merge at the right time.

@vhvb1989
Copy link
Member

vhvb1989 commented Dec 9, 2023

/check-enforcer override

@vhvb1989 vhvb1989 changed the title Update azure.yaml.json so support docker build target [Merge for 1.5.1] Update azure.yaml.json so support docker build target Dec 9, 2023
@vhvb1989 vhvb1989 merged commit 0a1faee into main Dec 13, 2023
3 checks passed
@vhvb1989 vhvb1989 deleted the Petermarcu-target-patch branch December 13, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants