New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to customize the azd up
workflow
#3173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some overall feedback - but looking really good.
Still a bit anxious about the fact that I really don't have a great understanding on the lifetime of any of our components and I am worried a little about how to decide about singleton vs scoped. My gut says I should really bias towards scoped unless I want sharing /across/ commands and in that case I need to be sure that my singleton data and scoped data don't comingle, or I can see odd behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more feedback - really happy here and going to take this and start building on top of it with my server work to use the new-workflow stuff. Need to still review container.go again but will try to sign off later tonight.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great work here @wbreza - thanks for addressing the feedback on the shape of the workflow steps in the YAML. I rebased my vs server work on top of this change and was able to leverage the workflow stuff and it all seems to be hanging together. Excited to get this landed and let it bake for a bit and have it as part of our Feb release!
FYI - You might want to do one more rebase or merge main in and then run the linters. @vhvb1989 added a few new calls to |
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSIContainer
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
This introduces a very basic concept of a workflow within the context of
azd
and leverages the workflow to allow customization of theazd up
command.azd
commands are run.azd
hooks are still executed for all referenced commandsazure.yaml
ConfigurationCompact configuration sample
Verbose configuration sample
azd up
commandThe
azd up
command has been updated to run a workflow calledup
if it exists.If the workflow does not exist it will use a default workflow of the following:
Technical Notes
Introduces the concept of a scoped lifetime to our IoC container. Each invocation of a command whether a root command or a sub command in a workflow now creates a new short lived lifetime.
Components of a scoped lifetime:
Addresses #2850