-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bicep-resource and input parameter #3349
Conversation
- support bicep - first version to create main.bicep - auto-detect outputs and list list them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some idle thoughts as I looked at the PR - Excited to see more of it.
It might be helpful to add one of the unit-tests that has checked in generated bicep so we can see the IaC the gets generated from a specific manifest, something like what we have in TestAspireDockerGeneration
in generate_test.go
, but with a manifest that uses this new bicep resource type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more comments - still digesting and I suspect I'll have a better understanding of this once I play around with some more examples.
Some more issues found when dogfooding this:
{
"resources": {
"redisrg": {
"type": "parameter.v0",
"value": "{redisrg.inputs.value}",
"inputs": {
"value": {
"type": "string"
}
}
},
"redisname": {
"type": "parameter.v0",
"value": "{redisname.inputs.value}",
"inputs": {
"value": {
"type": "string"
}
}
},
"redis": {
"type": "azure.bicep.v0",
"path": "redis.bicep",
"params": {
"redisCacheName": "{redisname.value}",
"rg": "{redisrg.value}",
"keyVaultName": ""
}
},
"cacheapi": {
"type": "project.v0",
"path": "../CacheApi/CacheApi.csproj",
"env": {
"OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EXCEPTION_LOG_ATTRIBUTES": "true",
"OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EVENT_LOG_ATTRIBUTES": "true",
"ConnectionStrings__redis": "{redis.secretOutputs.connectionString}"
},
"bindings": {
"http": {
"scheme": "http",
"protocol": "tcp",
"transport": "http"
},
"https": {
"scheme": "https",
"protocol": "tcp",
"transport": "http"
}
}
}
}
} This bicep resource has no connection string property and the secret output is directly referenced via an environment variable. |
Is this what you are seeing @davidfowl ? This is happening with |
This is the build I am using: |
I see it too. |
...ata/samples/aspire-full/AspireAzdTests.ServiceDefaults/AspireAzdTests.ServiceDefaults.csproj
Outdated
Show resolved
Hide resolved
…Tests.ServiceDefaults/AspireAzdTests.ServiceDefaults.csproj Co-authored-by: Wei Lim <weilim@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Didn't look too detailed into generate.go
-- but stuff we can harden over time.
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSIContainer
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
${AZURE_INPUT_PARAM}
fix: #3279
fix: #3278
fix: #3234