-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable DataProtection Runtime feature in ACA #3711
Enable DataProtection Runtime feature in ACA #3711
Conversation
This change does two things: - Supports using a custom api-version of the ACA CreateOrUpdate request by allowing the yaml deployment template to have an `api-version` property at top level. When set, this value is used as the `api-version` of the request. The request body is the object, rendered as JSON, with the `api-version` key removed. - Uses the above new feature to opt into the `2024-02-02-preview` in Aspire and sets the `configuration.runtime.dotnet.autoConfigureDataProtection` property to `true`. Fixes #3538
@mitchdenny - I played around with this and TestShop in the aspire playground today in the centraluseuap region and confirmed that the setting is getting set and persisted. I wasn't able to confirm if the end to end was working however, but maybe you have a clearer view. For some reason Log Analytics Workspaces can't be created in centraluseuap, so I had to I also had to manually set my region to |
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSIDocumentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
I spoke with the service team, and it would be safe for us to merge this as is. We can send this API version ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the detailed explanation for the custom API version usage in the SDK client!
is this in the main nightly build? Meaning if i just do the traditional update from the latest-and-hottest i'll have this feature? if so oh joy! |
@bradygaster Yes, give it an hour or so for this to get updated post a successful pipeline |
@bradygaster - Do note that the support on the ACA side is only in the EUAP regions today, and deploying there via |
This change does two things: - Supports using a custom api-version of the ACA CreateOrUpdate request by allowing the yaml deployment template to have an `api-version` property at top level. When set, this value is used as the `api-version` of the request. The request body is the object, rendered as JSON, with the `api-version` key removed. - Uses the above new feature to opt into the `2024-02-02-preview` in Aspire and sets the `configuration.runtime.dotnet.autoConfigureDataProtection` property to `true`, but only when the alpha feature `aspire.autoConfigureDataProtection` is turned on. We are gating turning this feature on behind a feature flag the user must opt-into instead of always sending this request, as we had done in #3711, because currently regions in Azure are rejecting the `2024-02-02-preview` requests (even though the error message implies this should work). This allows partners to test the end to end by running: `azd config set alpha.aspire.autoConfigureDataProtection on` And testing in a supported region, like `centraluseuap` (which can be explicitly selected via `azd env set AZURE_LOCATION centraluseuap`. Fixes #3538
This change does two things: - Supports using a custom api-version of the ACA CreateOrUpdate request by allowing the yaml deployment template to have an `api-version` property at top level. When set, this value is used as the `api-version` of the request. The request body is the object, rendered as JSON, with the `api-version` key removed. - Uses the above new feature to opt into the `2024-02-02-preview` in Aspire and sets the `configuration.runtime.dotnet.autoConfigureDataProtection` property to `true`, but only when the alpha feature `aspire.autoConfigureDataProtection` is turned on. We are gating turning this feature on behind a feature flag the user must opt-into instead of always sending this request, as we had done in #3711, because currently regions in Azure are rejecting the `2024-02-02-preview` requests (even though the error message implies this should work). This allows partners to test the end to end by running: `azd config set alpha.aspire.autoConfigureDataProtection on` And testing in a supported region, like `centraluseuap` (which can be explicitly selected via `azd env set AZURE_LOCATION centraluseuap`. Fixes #3538
This change does two things: - Supports using a custom api-version of the ACA CreateOrUpdate request by allowing the yaml deployment template to have an `api-version` property at top level. When set, this value is used as the `api-version` of the request. The request body is the object, rendered as JSON, with the `api-version` key removed. - Uses the above new feature to opt into the `2024-02-02-preview` in Aspire and sets the `configuration.runtime.dotnet.autoConfigureDataProtection` property to `true`, but only when the alpha feature `aspire.autoConfigureDataProtection` is turned on. We are gating turning this feature on behind a feature flag the user must opt-into instead of always sending this request, as we had done in #3711, because currently regions in Azure are rejecting the `2024-02-02-preview` requests (even though the error message implies this should work). This allows partners to test the end to end by running: `azd config set alpha.aspire.autoConfigureDataProtection on` And testing in a supported region, like `centraluseuap` (which can be explicitly selected via `azd env set AZURE_LOCATION centraluseuap`. Fixes #3538
This change does two things:
Supports using a custom api-version of the ACA CreateOrUpdate request by allowing the yaml deployment template to have an
api-version
property at top level. When set, this value is used as theapi-version
of the request. The request body is the object, rendered as JSON, with theapi-version
key removed.Uses the above new feature to opt into the
2024-02-02-preview
in Aspire and sets theconfiguration.runtime.dotnet.autoConfigureDataProtection
property totrue
.Fixes #3538