Add python-mongo template terraform #532

HadwaAbdelhalem · 2022-08-26T20:12:50Z

this PR adds the terraform modules code for todo-python-mongo template by adding :

Python-mongo infra terraform code.
application-insights, a common infra module, terraform code.
repo.yaml, and azure.yaml config files for the template repo generation.

➡Note : Target template remote to be created Azure-Samples/todo-python-mongo-terraform

➡Note : The generated template has a dependency on this issue being addressed rewrite module path normalization .

fixes #232

… list to match wider pattern repo*.yaml, refactor infra to infra/bicep in common, and common/projects

Co-authored-by: Hattan Shobokshi <hattan.shobokshi@microsoft.com>

Co-authored-by: Hadwa Gaber <hadwaa@microsoft.com>

Co-authored-by: Hattan Shobokshi <hattan.shobokshi@microsoft.com>

…ra-folders

Co-authored-by: Hattan Shobokshi <hattan.shobokshi@microsoft.com>

wbreza

Looking good so far - added a few comments.

templates/todo/projects/python-mongo/.repo/terraform/infra/main.tf

templates/todo/projects/python-mongo/.repo/terraform/infra/provider.tf

templates/common/infra/terraform/applicationinsights.tf

templates/common/infra/terraform/applicationinsights_variables.tf

templates/todo/projects/python-mongo/.repo/terraform/infra/apps.tf

templates/todo/projects/python-mongo/.repo/terraform/infra/variables.tf

templates/todo/projects/python-mongo/.repo/terraform/infra/database.tf

templates/todo/projects/python-mongo/.repo/terraform/infra/keyvault.tf

templates/todo/projects/python-mongo/.repo/terraform/infra/main.tf

karolz-ms · 2022-08-30T02:40:36Z

@HadwaAbdelhalem are you planning to add launch.json and tasks.json files for local development?

We might want to reuse them between this template and the Bicep-based one. This would require moving them to a shared folder.

wbreza

Looking great - a few more comments around the appinsights module.

templates/common/infra/terraform/applicationinsights.tf

templates/todo/projects/python-mongo/.repo/terraform/infra/loganalytics.tf

templates/todo/projects/python-mongo/.repo/terraform/infra/main.tf

HadwaAbdelhalem · 2022-09-01T17:40:40Z

@HadwaAbdelhalem are you planning to add launch.json and tasks.json files for local development?

We might want to reuse them between this template and the Bicep-based one. This would require moving them to a shared folder.

@karolz-ms , I had them in a previous PR. and received feedback to exclude them as they are specific tothe todo-apps 60a463b

templates/todo/projects/python-mongo/.repo/terraform/azure.yaml

wbreza

Looking great, thank you!

templates/todo/projects/python-mongo/.repo/terraform/azure.yaml

karolz-ms · 2022-09-01T20:22:45Z

@HadwaAbdelhalem are you planning to add launch.json and tasks.json files for local development?
We might want to reuse them between this template and the Bicep-based one. This would require moving them to a shared folder.

@karolz-ms , I had them in a previous PR. and received feedback to exclude them as they are specific tothe todo-apps 60a463b

@HadwaAbdelhalem and I synced offline. The VS Code files will be included automatically as part of template generation; and the files that we have for Python-Mongo flavor of the ToDo app will work unchanged.

azure-sdk · 2022-09-02T03:37:34Z

Repoman Generation Results

Repoman pushed changes to remotes for the following projects:

Project: todo-python-mongo-terraform

Remote: azure-samples-staging

Branch: pr/532

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo-terraform -b pr/532

View Changes | Compare Changes

hattan and others added 23 commits August 3, 2022 12:09

adding in cse fork changes

528f9ad

adding vscode debugging support

60a463b

adding .tmp folder to gitignore

68e6947

refator to support bicep in folder structure

362572c

update repoman to add new rule to copy specific files, update repoman…

3d18273

… list to match wider pattern repo*.yaml, refactor infra to infra/bicep in common, and common/projects

add aca/bicep layer in common infra folders

f2152c3

Co-authored-by: Hattan Shobokshi <hattan.shobokshi@microsoft.com>

update to set -t to the project template

bb37d8a

Co-authored-by: Hattan Shobokshi <hattan.shobokshi@microsoft.com>

update node-js-mongo project

6e115b0

Co-authored-by: Hattan Shobokshi <hattan.shobokshi@microsoft.com>

update repo.yaml files to reference common/infra/bicep

222007b

Co-authored-by: Hattan Shobokshi <hattan.shobokshi@microsoft.com>

Removing extra lines in python-mongo azure*.yaml files.

de0f308

Co-authored-by: Hadwa Gaber <hadwaa@microsoft.com>

Code Cleanup

c1b9754

Co-authored-by: Hattan Shobokshi <hattan.shobokshi@microsoft.com>

redirect configurations to upstream azure/azure-dev

d3fb35d

Co-authored-by: Hattan Shobokshi <hattan.shobokshi@microsoft.com>

address bicep lint failures

ec30798

Co-authored-by: Hattan Shobokshi <hattan.shobokshi@microsoft.com>

Update todo-project template.

dd99040

Co-authored-by: Hattan Shobokshi <hattan.shobokshi@microsoft.com>

Merge remote-tracking branch 'upstream/main' into cse/restructure-inf…

f38bf69

…ra-folders

fix asset rules for path rewitre

861e34a

Co-authored-by: Hattan Shobokshi <hattan.shobokshi@microsoft.com>

Add rewrite path rules tmp fix

9e1fa5a

Co-authored-by: Hattan Shobokshi <hattan.shobokshi@microsoft.com>

add python-mongo, application insights terraform modules

c0657b3

add repo.yml, azure.yml files

616f1a0

fix asset rules

6e0cb75

ignore terraform files

f7d4c4b

Co-authored-by: Hattan Shobokshi <hattan.shobokshi@microsoft.com>

merge upstream main

1e4730c

update remote main and staging urls

5d139d8

Co-authored-by: Hattan Shobokshi <hattan.shobokshi@microsoft.com>

HadwaAbdelhalem requested review from jongio, wbreza and ellismg as code owners August 26, 2022 20:12

HadwaAbdelhalem changed the title ~~add python-mongo template terraform~~ Add python-mongo template terraform Aug 26, 2022

HadwaAbdelhalem linked an issue Aug 26, 2022 that may be closed by this pull request

Terraform support for todo-python-mongo template #232

Closed

2 tasks

HadwaAbdelhalem requested a review from hattan August 26, 2022 20:17

HadwaAbdelhalem self-assigned this Aug 26, 2022

wbreza reviewed Aug 27, 2022

View reviewed changes

addreses PR feedback

3c7e7b7

HadwaAbdelhalem requested a review from ellismg August 27, 2022 01:39

HadwaAbdelhalem added 2 commits August 26, 2022 18:47

update template name

bd7de3f

split resources in multiple files.

01188dd

hattan mentioned this pull request Aug 28, 2022

Repoman - Adding relative base path ./ to path rewrites. #537

Merged

resolve cspell

17dc803

jongio reviewed Aug 29, 2022

View reviewed changes

templates/todo/projects/python-mongo/.repo/terraform/infra/database.tf Outdated Show resolved Hide resolved

jongio reviewed Aug 29, 2022

View reviewed changes

templates/todo/projects/python-mongo/.repo/terraform/infra/database.tf Outdated Show resolved Hide resolved

jongio reviewed Aug 29, 2022

View reviewed changes

templates/todo/projects/python-mongo/.repo/terraform/infra/keyvault.tf Show resolved Hide resolved

jongio reviewed Aug 29, 2022

View reviewed changes

templates/todo/projects/python-mongo/.repo/terraform/infra/main.tf Show resolved Hide resolved

address review comments

65bee8b

wbreza reviewed Aug 30, 2022

View reviewed changes

ellismg reviewed Sep 1, 2022

View reviewed changes

templates/todo/projects/python-mongo/.repo/terraform/azure.yaml Show resolved Hide resolved

wbreza approved these changes Sep 1, 2022

View reviewed changes

templates/todo/projects/python-mongo/.repo/terraform/azure.yaml Show resolved Hide resolved

templates/todo/projects/python-mongo/.repo/terraform/azure.yaml Show resolved Hide resolved

HadwaAbdelhalem added 2 commits September 1, 2022 13:18

Merge branch 'main' into cse/add-template-terraform

44f3620

add tfvars.json

b9691cd

HadwaAbdelhalem added 2 commits September 1, 2022 16:24

Merge branch 'main' into cse/add-template-terraform

18635d9

add rewrite path rules

3cccab7

HadwaAbdelhalem requested a review from ellismg September 1, 2022 23:58

HadwaAbdelhalem added 2 commits September 1, 2022 18:25

rename to environment_name

bd804fb

Merge branch 'main' into cse/add-template-terraform

a71cbbf

HadwaAbdelhalem linked an issue Sep 2, 2022 that may be closed by this pull request

Terraform python mongo template resource token seed #574

Closed

HadwaAbdelhalem removed a link to an issue Sep 2, 2022

Terraform python mongo template resource token seed #574

Closed

HadwaAbdelhalem merged commit 30f66b9 into Azure:main Sep 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add python-mongo template terraform #532

Add python-mongo template terraform #532

HadwaAbdelhalem commented Aug 26, 2022 •

edited

wbreza left a comment

karolz-ms commented Aug 30, 2022

wbreza left a comment

HadwaAbdelhalem commented Sep 1, 2022

wbreza left a comment

karolz-ms commented Sep 1, 2022

azure-sdk commented Sep 2, 2022

Add python-mongo template terraform #532

Add python-mongo template terraform #532

Conversation

HadwaAbdelhalem commented Aug 26, 2022 • edited

wbreza left a comment

Choose a reason for hiding this comment

karolz-ms commented Aug 30, 2022

wbreza left a comment

Choose a reason for hiding this comment

HadwaAbdelhalem commented Sep 1, 2022

wbreza left a comment

Choose a reason for hiding this comment

karolz-ms commented Sep 1, 2022

azure-sdk commented Sep 2, 2022

Repoman Generation Results

Project: todo-python-mongo-terraform

Remote: azure-samples-staging

Branch: pr/532

HadwaAbdelhalem commented Aug 26, 2022 •

edited