minor change in pip helper and steps to validate that it works #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauravsaralMs
added
Task
atbagga
requested changes
Feb 7, 2019
There was a problem hiding this comment.
A lot of inline script code we are adding in yml is making the pipelines complex.
- Whatever we need in the pipeline will also be required by the developer (most cases) so it makes sense to add these scripts in the code repo itself.
- Since the pipelines are harder to debug, using locally tested scripts in the pipelines will keep the pipelines up-to-date and easy to debug.
We should keep the issue #413 in mind when making changes in the pipeline.
I did raise a PR #412 to start with this work but since a lot of changes were made in the pipeline yml code some of those got outdated already.
added 6 commits
February 8, 2019 09:16
atbagga
approved these changes
Feb 8, 2019
ishitam8
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure the code is following contribution guidelines in CONTRIBUTING.md
Changes include:
Install keyring and other packages to extension folder.
This is needed because in some systems user will not have permission to install packages at machine level (like azure shell)
Do not pack test when creating whl because we should not be shipping tests to client machines
While running UTs let it discover modules in extension folder. The local files module will still get preference over modules in extension dir