Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes : Handle long list of service connections and Github file checkin failure in pipeline create command #568

Merged
merged 8 commits into from
May 2, 2019

Conversation

atbagga
Copy link
Collaborator

@atbagga atbagga commented Apr 30, 2019

Bug Fixes in az pipeline create command:

  1. Handle long list of service connections in pipeline create (filter the list to only connections create by the user or App connections
  2. Handle github file checkin failures by raising appropriate error

@atbagga atbagga added the in progress Development in progress label Apr 30, 2019
@atbagga atbagga removed the in progress Development in progress label May 2, 2019
@atbagga atbagga self-assigned this May 2, 2019
Copy link
Contributor

@gauravsaralMs gauravsaralMs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user will end up seeing a different service endpoint list in CLI and in UI..

If we doing this just to get around friendly_prompt_list issue
then I will suggest the following

  1. Do a proper fix in friendly_prompt_lis
  2. Build some kind of loop in friendly_prompt_lis
    like end option can be (see more options) basically pagination kind of thing

if endpoint.authorization.scheme == 'InstallationToken':
service_endpoints_choice_list.append('{} {}'.format(endpoint.name, '(Recommended)'))
else:
if (endpoint.authorization.scheme == 'InstallationToken' or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get_service_endpoints in the client takes scheme as a param for filtering... can we use that one?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I cannot use that filter here..

Reason: I need all service connections created by me or the ones with auth scheme = installationtoken.
I will still need to pass all auth schemes to get_service_endpoints since I need my service endpoints which may or may not be InstallationToken scheme.

Good catch on the functionality being available though. I had missed that.

@atbagga
Copy link
Collaborator Author

atbagga commented May 2, 2019

The user will end up seeing a different service endpoint list in CLI and in UI..

If we doing this just to get around friendly_prompt_list issue
then I will suggest the following

  1. Do a proper fix in friendly_prompt_lis
  2. Build some kind of loop in friendly_prompt_lis
    like end option can be (see more options) basically pagination kind of thing

We will have to fix the list and I will do that. Here the intention is to actually reduce the options also since we do not want the user to have 400 options to choose from.
These are the service endpoints which will be most likely used.

I have raised an issue to fix the list. #571

@atbagga atbagga changed the title Filter Service Connections to only ones created by me or app token Bug fixes : Handle long list of service connections and Github file checkin failure in pipeline create command May 2, 2019
@atbagga atbagga merged commit 056684d into master May 2, 2019
@atbagga atbagga deleted the users/atbagga/truncatesclist branch May 6, 2019 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants