Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle proton:io errors with meaningful error msg #427

Merged
merged 2 commits into from
Jan 29, 2019

Conversation

JamesBirdsall
Copy link
Contributor

Description

Convert proton:io ErrorCondition into CommunicationException. In some cases, such as DNS resolution failure, the message in the ErrorCondition is null, so substitute a useful generic message in those cases.

This checklist is used to make sure that common guidelines for a pull request are followed.

  • I have read the contribution guidelines.
  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).
  • If applicable, the public code is properly documented.
  • Pull request includes test coverage for the included changes.
  • The code builds without any errors.

@JamesBirdsall JamesBirdsall merged commit 120231b into Azure:dev Jan 29, 2019
@JamesBirdsall JamesBirdsall deleted the dnsfix branch February 5, 2019 21:37
Jgomez13 pushed a commit that referenced this pull request May 17, 2024
* Handle proton:io errors with meaningful error msg

* Use Proton-supplied message if present
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants