Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type of EventData.applicationProperties #50

Merged
merged 6 commits into from
Feb 21, 2017

Conversation

SreeramGarlapati
Copy link
Contributor

@SreeramGarlapati SreeramGarlapati commented Feb 6, 2017

Addresses (#49)
This PR fixes an AMQP spec violation for the AmqpMessage Properties, which is also a breaking change.

3.2.5 Application Properties:

The keys of this map are restricted to be of type string (which excludes the possibility of a null key) and the values are restricted to be of simple types only, that is, excluding map, list, and array types.

@msftclas
Copy link

msftclas commented Feb 6, 2017

Hi @SreeramGarlapati, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Sreeram Kumar Garlapati). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@sjkwak sjkwak merged commit ceec052 into Azure:master Feb 21, 2017
@jtaubensee jtaubensee modified the milestone: 0.11.0 Feb 24, 2017
Jgomez13 pushed a commit that referenced this pull request May 17, 2024
* Fix type of EventData.ApplicationProperties to Map<String, Object>

* move to 0.11.0-snapshot

* change pom.xml to 0.11.0-snapshot

* remove/markInternal unused code to avoid showing up in msdndocs - EventHubRuntimeInfo, BatchSender

* Backcompat cit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants