Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core-tools .funcignore does not ignore sub-directories when it should #1745

Open
madelinegordon opened this issue Jan 6, 2020 · 1 comment
Milestone

Comments

@madelinegordon
Copy link
Contributor

madelinegordon commented Jan 6, 2020

There are multiple issues with the current implementation of the .funcignore parser:

  • When for example test2 is included in the .funcignore file, it should ignore /test2 and abc/test2
    (this is also the case for when /test2 is included in the .funcignore file.)

  • When test/ is included in the .funcignore file, the directory a/test should be ignored.

These are determined as issues in accordance with current .gitignore patterns.

@kf6kjg
Copy link

kf6kjg commented Jul 27, 2023

See #2701 for details. It turns out that there's a deep seated problem with the interpretation of the .funcignore file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants