-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.funcignore does not support wildcards #2701
Comments
According to
I recommend removing the DIY parser in favor of https://github.com/goelhardik/ignore or similar to gain full gitignore syntax compliance and less maintenance headaches. |
Short term bandaid hack workaround found using BASH/ZSH.
deploy() {
rm -f .funcignore
npm run build \
&& git ls-files --cached --others --ignored --exclude-from=.funcignore.source > .funcignore \
&& echo '.funcignore' >> .funcignore \
&& func azure functionapp publish "$@" --typescript;
}
Note that user of other languages would need to modify the above, but the user of this hack should be able to work out how to integrate it. |
Is |
@th0ger I cannot either. That said the code itself appears to be designed with the intention of using gitignore syntax, and this is supported by the posts around the introduction of the feature and the commit message that introduced it. #341 (comment) Additionally the default funcignore file generated by the cli uses globs in gitignore style - globs that do not work at the moment. |
Since this seems to be a bigger issue and will take a while to fix, should we maybe update the cli to generate files that will actually work in the meantime and add a warning to the documentation? |
Adding a wildcard to the .funcignore has no effect.
The text was updated successfully, but these errors were encountered: