Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning no Connection String when using managed identity - CLI #2552

Closed
cachai2 opened this issue Mar 29, 2021 · 8 comments · Fixed by #2652
Closed

Warning no Connection String when using managed identity - CLI #2552

cachai2 opened this issue Mar 29, 2021 · 8 comments · Fixed by #2652
Assignees

Comments

@cachai2
Copy link

cachai2 commented Mar 29, 2021

For the new secretless triggers/bindings, they no longer use connection strings. However, our CLI will throw warnings when connection strings aren't used despite not being in a warning state. We should remove the warnings for secretless. This is a potential preview blocker for Track 2 sdk triggers.

Files to update:
line 426: https://github.com/Azure/azure-functions-core-tools/blob/6a070fb40308438c758ba8ab69399845bd698391/src/Azure.Functions.Cli/Actions/HostActions/StartHostAction.cs

line 120: https://github.com/Azure/azure-functions-core-tools/blob/6a070fb40308438c758ba8ab69399845bd698391/test/Azure.Functions.Cli.Tests/ActionsTests/StartHostActionTests.cs

@fabiocav
Copy link
Member

@cachai2 just want to clarify, this is for Core Tools and not CLI, correct? I'll move to the appropriate repo for now.

@fabiocav fabiocav transferred this issue from Azure/Azure-Functions Apr 14, 2021
@ghost ghost added the Needs: Triage 🔍 label Apr 14, 2021
@fabiocav fabiocav added this to the Functions Sprint 100 milestone Apr 14, 2021
@fabiocav
Copy link
Member

Can you also clarify the priority on this? We're having a difficult time with the assignment

@cachai2
Copy link
Author

cachai2 commented Apr 14, 2021

This is a high P2 for preview. P1 (blocker) for GA.

@fabiocav
Copy link
Member

@karshinlin is this something you're expecting to pick up?

@fabiocav
Copy link
Member

@cachai2 assigning this to sprint 102, but this is still pending assignment.

@fabiocav
Copy link
Member

Moving to 105, PR in progress.

@fabiocav
Copy link
Member

fabiocav commented Jul 7, 2021

Work nearing completion, leaving this assigned to 105

@fabiocav
Copy link
Member

@madelinegordon opening a PR as we're blocked on some test scenarios. Moving to 106 as we'll be iterating and merging the PR then.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants