Support secretless extensions #2652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettsam
reviewed
Jul 22, 2021
| var secrets = new Dictionary<string, string>() | ||
| { | ||
| { "AzureWebJobsStorage:blobServiceUri", "myuri" }, | ||
| { "AzureWebJobsStorage:queueServiceUri", "queueuri" } |
There was a problem hiding this comment.
Can you make this one use AzureWebJobsStorage__queueServiceUri to check that block of code?
| [Fact] | ||
| public async Task CheckNonOptionalSettingsDoesntThrowMissingStorageUsingManagedIdentity() | ||
| { | ||
|
|
There was a problem hiding this comment.
nit -- remove this blank line. Some of our repos will log a build warning for this -- but this one must not.
brettsam
approved these changes
Jul 22, 2021
brettsam
pushed a commit
that referenced
this pull request
Jul 26, 2021
* add check to config section for conn string * how to simulate managed identity? * added unit test * edit error message * PR changes * space between tests
brettsam
pushed a commit
that referenced
this pull request
Jul 26, 2021
* add check to config section for conn string * how to simulate managed identity? * added unit test * edit error message * PR changes * space between tests
brettsam
pushed a commit
that referenced
this pull request
Jul 26, 2021
* add check to config section for conn string * how to simulate managed identity? * added unit test * edit error message * PR changes * space between tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer throw warning when customer uses managed identity (rather than a connection string) to connect to service.
Fixes #2552