Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error message recommendation for python version #2008

Merged
merged 1 commit into from
May 27, 2020
Merged

Update error message recommendation for python version #2008

merged 1 commit into from
May 27, 2020

Conversation

mhoeger
Copy link
Contributor

@mhoeger mhoeger commented May 27, 2020 •
edited

Resolves #1979

@mhoeger
Copy link
Contributor Author

mhoeger commented May 27, 2020

@anthonychu - thoughts on message?

This was referenced May 27, 2020
Closed
Closed
anthonychu
anthonychu approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@anthonychu anthonychu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Message looks good. Just a small comment about VS Code terminal behavior. Thanks!

src/Azure.Functions.Cli/Helpers/PythonHelpers.cs Show resolved Hide resolved
@mhoeger mhoeger merged commit 5c1c013 into dev May 27, 2020
@ahmelsayed ahmelsayed deleted the pythonMessageUpdateV2 branch August 7, 2020 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonychu anthonychu anthonychu approved these changes

@ankitkumarr ankitkumarr Awaiting requested review from ankitkumarr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Core Tools V2 - recommend upgrading to V3 if using Python 3.8
2 participants
@mhoeger @anthonychu