Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default logging filters - rely on LoggerFilterOptions #2223

Merged
merged 4 commits into from Sep 18, 2020
Merged

Fix default logging filters - rely on LoggerFilterOptions #2223

merged 4 commits into from Sep 18, 2020

Conversation

pragnagopa
Copy link
Member

@pragnagopa pragnagopa commented Sep 11, 2020 •
edited

Resolves #2216 and Resolves #2220

  • Use registered LoggerFilterOptions to filter logs
    • Default log levels apply only if LoggingFilterRule does not have a logLevel for a category.

Resolves #2217

  • Bring back time stamps in the logs
  • Print Function Executing and Executed messages.

@pragnagopa pragnagopa changed the title Add ScriptEnvironmentVariablesConfigurationSource Fix default logging filters, add ScriptEnvironmentVariablesConfigurationSource Sep 11, 2020
@pragnagopa
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

fabiocav
fabiocav requested changes Sep 14, 2020
View reviewed changes
src/Azure.Functions.Cli/Common/Utilities.cs Outdated Show resolved Hide resolved
src/Azure.Functions.Cli/Common/Utilities.cs Outdated Show resolved Hide resolved
src/Azure.Functions.Cli/Common/Utilities.cs Outdated Show resolved Hide resolved
@pragnagopa pragnagopa changed the title Fix default logging filters, add ScriptEnvironmentVariablesConfigurationSource Fix default logging filters - rely on LoggerFilterOptions Sep 15, 2020
@pragnagopa
Copy link
Member Author

@brettsam / @fabiocav - PR is ready for review. Addressed feedback, added more unit tests.

@pragnagopa
Copy link
Member Author

@Francisco-Gamino - please wait for this PR to be merged before preparing CLI build for OGFs. Thanks!

@pragnagopa
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pragnagopa pragnagopa merged commit d552c67 into v3.x Sep 18, 2020
@pragnagopa pragnagopa deleted the pgopa/loggingFixes branch September 18, 2020 22:44
@pragnagopa pragnagopa mentioned this pull request Sep 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettsam brettsam brettsam approved these changes

@fabiocav fabiocav fabiocav approved these changes

@ankitkumarr ankitkumarr Awaiting requested review from ankitkumarr

@anthonychu anthonychu Awaiting requested review from anthonychu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pragnagopa @brettsam @fabiocav