CORS with Access-Control-Allow-Credentials #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ine argument to enable Access-Control-Allow-Credentials.
|
|
ahmelsayed
requested changes
Nov 19, 2018
There was a problem hiding this comment.
nit: can you change the parameter to cors-credentials instead? I know this action has a couple with camelCasing, but I have been trying to stick to - separators moving forward. I'm planning to add an alias for useHttps and a couple other inconsistent args in other actions and hide them from the help.
Thanks for your contribution 👍
…o cors-credentials.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This won't fix the problem in Azure (Azure/azure-functions-host#620), but it's still useful for local development where you don't want to have to put all your services behind a proxy.