Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blob converter for ParameterBindingData support #1108

Merged
merged 41 commits into from
Feb 8, 2023

Conversation

liliankasem
Copy link
Member

@liliankasem liliankasem commented Oct 6, 2022

Issue describing the changes in this PR

Related epic: #1081

Part of the work to support SDK-type bindings for out-of-proc workers is to write a BlobConverter that can handle the new ModelBindingData type. The ModelBindingData type contains information that we can use to hydrate the client, so the job of the converter here is to parse the content provided to extract the relevant information, and use that to create the requested type (requested type being what the user is binding to).

  • ModelBindingData was added to the protobuf and brought into this repo via this PR
  • We updated the SDK to use the ModelBindingData in this PR. The SDK will check to see if a given extension supports deferred binding, and if it does, it will set the flag so that the host uses this ModelBindingData type for each function it is supported

The epic has a list of all the PRs related to this if you'd like to follow the progress of how ModelBindingData came to be.

Pull request checklist

  • My changes do not require documentation changes
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)
    • Working on this

Additional information

Additional PR information

DotNetWorker.sln Outdated Show resolved Hide resolved
@liliankasem liliankasem force-pushed the sdk-bindings/blob-sdk-converter branch from 37f7bf5 to d1f7072 Compare October 27, 2022 20:12
@liliankasem liliankasem force-pushed the sdk-bindings/reference-support branch 2 times, most recently from 7817039 to 084dced Compare November 1, 2022 22:16
@liliankasem liliankasem changed the base branch from sdk-bindings/reference-support to sdk-bindings/support-reference-type November 2, 2022 18:02
@liliankasem liliankasem changed the base branch from sdk-bindings/support-reference-type to sdk-bindings/reference-support November 2, 2022 18:03
@liliankasem liliankasem force-pushed the sdk-bindings/blob-sdk-converter branch from 568045c to e71e7a5 Compare November 2, 2022 18:08
Base automatically changed from sdk-bindings/reference-support to main November 3, 2022 17:49
@liliankasem liliankasem force-pushed the sdk-bindings/blob-sdk-converter branch from f0d3ed4 to ca52242 Compare February 8, 2023 01:45
@liliankasem liliankasem merged commit c435dda into main Feb 8, 2023
@liliankasem liliankasem deleted the sdk-bindings/blob-sdk-converter branch February 8, 2023 23:50
liliankasem added a commit that referenced this pull request Jul 14, 2023
Co-authored-by: Surgupta <surgupta@microsoft.com>
liliankasem added a commit that referenced this pull request Jul 17, 2023
Co-authored-by: Surgupta <surgupta@microsoft.com>
liliankasem added a commit that referenced this pull request Jul 17, 2023
Co-authored-by: Surgupta <surgupta@microsoft.com>
liliankasem added a commit that referenced this pull request Jul 18, 2023
Co-authored-by: Surgupta <surgupta@microsoft.com>
liliankasem added a commit that referenced this pull request Jul 20, 2023
Co-authored-by: Surgupta <surgupta@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants