Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] HttpResponseData handling in ASP.NET Core Integration #2488

Merged
merged 4 commits into from
May 29, 2024

Conversation

satvu
Copy link
Member

@satvu satvu commented May 28, 2024

Issue describing the changes in this PR

resolves #2479, may also fix #2487

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@satvu satvu force-pushed the satvu/bug-fix-http-response-data branch from 6c51d0b to 78bbe34 Compare May 28, 2024 21:32
@satvu satvu requested review from fabiocav and kshyju May 28, 2024 21:34
@satvu satvu merged commit b6ad812 into main May 29, 2024
21 checks passed
@satvu satvu deleted the satvu/bug-fix-http-response-data branch May 29, 2024 03:00
@@ -72,7 +72,7 @@ private static async Task<bool> TryHandleHttpResult(object? result, FunctionCont
ActionContext actionContext = new ActionContext(httpContext, httpContext.GetRouteData(), new ActionDescriptor());
await actionResult.ExecuteResultAsync(actionContext);
break;
case AspNetCoreHttpRequestData when isInvocationResult:
case AspNetCoreHttpResponseData when isInvocationResult:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants