Skip to content

Commit

Permalink
Adding support for source-link (#528)
Browse files Browse the repository at this point in the history
* Includes changes to use embedded PDBs
* Also fixes a bug preventing startup for Functions 1.0 apps
  • Loading branch information
gled4er authored and cgillum committed Nov 28, 2018
1 parent 21362fb commit 653c8f1
Show file tree
Hide file tree
Showing 3 changed files with 39 additions and 35 deletions.
3 changes: 2 additions & 1 deletion src/WebJobs.Extensions.DurableTask/DurableTaskExtension.cs
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ public class DurableTaskExtension :

private readonly AsyncLock taskHubLock = new AsyncLock();

private readonly INameResolver nameResolver;
private readonly bool isOptionsConfigured;

private INameResolver nameResolver;
private AzureStorageOrchestrationService orchestrationService;
private AzureStorageOrchestrationServiceSettings orchestrationServiceSettings;
private TaskHubWorker taskHubWorker;
Expand Down Expand Up @@ -203,6 +203,7 @@ private void InitializeForFunctionsV1(ExtensionConfigContext context)
this.Options,
context.Config.NameResolver,
this.TraceHelper);
this.nameResolver = context.Config.NameResolver;
#endif
}

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,17 @@
<Company>Microsoft Corporation</Company>
<SignAssembly>true</SignAssembly>
<AssemblyOriginatorKeyFile>..\..\sign.snk</AssemblyOriginatorKeyFile>
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<EmbedUntrackedSources>true</EmbedUntrackedSources>
<DebugSymbols>true</DebugSymbols>
<DebugType>embedded</DebugType>
<IncludeSymbols>false</IncludeSymbols>
</PropertyGroup>


<ItemGroup>
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0-*" PrivateAssets="All" />
</ItemGroup>

<ItemGroup Condition="'$(Configuration)' == 'Debug'">
<PackageReference Include="StyleCop.Analyzers" Version="1.1.0-beta009">
<PrivateAssets>all</PrivateAssets>
Expand Down

0 comments on commit 653c8f1

Please sign in to comment.