Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maximum and custom polling duration to DurableHttpRequest #1278

Closed
bachuv opened this issue Mar 18, 2020 · 0 comments · Fixed by #1547
Closed

Add maximum and custom polling duration to DurableHttpRequest #1278

bachuv opened this issue Mar 18, 2020 · 0 comments · Fixed by #1547
Assignees
Labels
Enhancement Feature requests.

Comments

@bachuv
Copy link
Collaborator

bachuv commented Mar 18, 2020

This issue is pulled from a comment made in the "Allow custom polling behavior in CallHttpAsync() for long-running endpoints" issue.

The comments say:
"Second, it would be nice to be able to specify an overall maximum polling duration, after which it could throw a time out exception.

Third, from my experiments it seems that the original HTTP request will time out in just under 90 seconds. It would be nice to be able to control that timeout duration with another property on DurableHttpRequest."

Here are some solutions to this issue:
An additional property (e.g. maximumPollingDuration) can be added to DurableHttpRequest to keep track of an overall maximum polling duration.

An additional property (e.g. timeOutDuration) can be added to DurableHttpRequest to specify if there is a custom timeout duration for the original HTTP request.

@ghost ghost added the Needs: Triage 🔍 label Mar 18, 2020
@amdeel amdeel added Enhancement Feature requests. and removed Needs: Triage 🔍 labels May 22, 2020
@cgillum cgillum added this to the Extension vNext milestone Aug 27, 2020
bachuv added a commit that referenced this issue Nov 23, 2020
These changes resolve #1278 by adding a `Timeout` property to `DurableHttpRequest`. This property defines the timeout for each individual HTTP request. This timeout applies to each asynchronous polling request too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Feature requests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants