Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added RestartAsync API to rerun existing orchestrator instances #1545

Merged
merged 7 commits into from
Nov 25, 2020
Merged

Conversation

amdeel
Copy link
Contributor

@amdeel amdeel commented Nov 3, 2020

Added RestartAsync(string instanceId, bool restartWithNewInstanceId = true) API to rerun orchestrators. Given a valid instance Id of an existing orchestrator, a new orchestrator will be started reusing the same input.

restartWithNewInstanceId is an optional input determining if the started orchestrator instance should reuse the same instance Id or be started with a new instance Id.

resolves #1243

Copy link
Contributor

@ConnorMcMahon ConnorMcMahon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good start, but there are a few design things left to consider.

Copy link
Contributor

@ConnorMcMahon ConnorMcMahon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting close to ready to merge. A few nits, but some can be put off into a different issue.

@@ -352,7 +361,7 @@ public async Task<HttpResponseMessage> HandleRequestAsync(HttpRequestMessage req
return request.CreateResponse(HttpStatusCode.NotFound);
}
}
else
else if (request.Method == HttpMethod.Post)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should document this as a bug fix in the release notes.

src/WebJobs.Extensions.DurableTask/HttpApiHandler.cs Outdated Show resolved Hide resolved
src/WebJobs.Extensions.DurableTask/HttpApiHandler.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@ConnorMcMahon ConnorMcMahon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add webhook to rerun failed (or terminated) orchestrations
2 participants