-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added RestartAsync API to rerun existing orchestrator instances #1545
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good start, but there are a few design things left to consider.
src/WebJobs.Extensions.DurableTask/ContextImplementations/DurableClient.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Extensions.DurableTask/ContextImplementations/DurableClient.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting close to ready to merge. A few nits, but some can be put off into a different issue.
@@ -352,7 +361,7 @@ public async Task<HttpResponseMessage> HandleRequestAsync(HttpRequestMessage req | |||
return request.CreateResponse(HttpStatusCode.NotFound); | |||
} | |||
} | |||
else | |||
else if (request.Method == HttpMethod.Post) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should document this as a bug fix in the release notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Added RestartAsync(string instanceId, bool restartWithNewInstanceId = true) API to rerun orchestrators. Given a valid instance Id of an existing orchestrator, a new orchestrator will be started reusing the same input.
restartWithNewInstanceId is an optional input determining if the started orchestrator instance should reuse the same instance Id or be started with a new instance Id.
resolves #1243