Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Timeout Property to DurableHttpRequest #1547
Adding Timeout Property to DurableHttpRequest #1547
Changes from 3 commits
1dbea16
0dda144
14b38c0
3638ac4
c7cc876
875772b
62353e7
2b75ee8
1f5e04d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make this more accurate, it could be
catch (OperationCanceledException ex) when (cts.Token.IsCancellationRequested)
(added the commented out part). This way we know that the exception came when a cancel request was sent toCancellationTokenSource
. The only issue with this is adding tests that mirror the action of cancelling aCancellationTokenSource
. TheMock<HttpMessageHandler>
Setup call takesItExpr.IsAny<CancellationToken>()
and the test would need theCancellationTokenSource
to cancel the task, not theCancellationToken
.I saw that that
ItExpr.IsAny()
could evaluate conditions, but didn't see anything about sending in another object to manipulate. Let me know if there's a way to pass in a CancellationTokenSource using Moq.This is how the
HttpMessageHandler
is mocked right now:Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.