Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand long running timer functionality to WaitForExternalEvent #1550

Merged
merged 2 commits into from
Nov 6, 2020
Merged

Expand long running timer functionality to WaitForExternalEvent #1550

merged 2 commits into from
Nov 6, 2020

Commits on Nov 5, 2020

  1. Expand long running timer functionality to WaitForExternalEvent 

    Internally WaitForExternalEvent with a timeout uses a timer. In v2.3.0
we added support for long-running timers, we just didn't remove the
now unecessary validation from the WaitForExternalEvent API. This PR
validates the scenario with a test and removes this validation.

Note that initially this PR attempted to expand this functionality to
RetryOptions in CallActivity/SubOrchestrationWithRetry, but
unfortunately the timer used by that retry is lower level than the
Durable Functions layer, meaning we can't use our long-running support.

Addresses #1538
    Connor McMahon committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    4f62de2 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2020

  1. Address pr feedback and remove invalid tests

    Connor McMahon committed Nov 6, 2020
    Configuration menu
    Copy the full SHA
    1bf532a View commit details
    Browse the repository at this point in the history