Added StealAppLease API and HTTP API #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmrdavid
reviewed
Apr 6, 2021
| /// <summary> | ||
| /// Steals AppLease if this app doesn't already have it. To use this, must be using the AppLease feature by setting UseAppLease to true in host.json. | ||
| /// </summary> | ||
| /// <returns>A task that completes when the steal app message is written to storage.</returns> |
There was a problem hiding this comment.
Just for clarity: is writing the steal message to storage the same as completing the process of stealing the lease, or is it just a starting step in that process?
There was a problem hiding this comment.
It should just be the the starting step. We may want to clarify the operation to be "InitiateStealAppLeaseOperationAsync()`.
There was a problem hiding this comment.
We probably want to be explicit in the documentation saying that this kicks off the process to cause this application to steal the app lease.
davidmrdavid
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added StealAppLease API and HTTP API to support app lease swap without turning off a function instance.
Extension side work for this issue: #1503
Pull request checklist
pending_docs.mdrelease_notes.md