Change local RPC port selection logic #1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current RPC port selection logic favors ephemeral ports. This leads to issues with the web apps sandbox. Instead, we now use randomized port selection from an approved range of ports.
ConnorMcMahon
commented
Apr 26, 2021
| numAttempts++; | ||
| var random = new Random(); |
There was a problem hiding this comment.
This randomized delay is no longer necessary as we don't have a semi-deterministic mechanism for selecting ports anymore, so it doesn't matter if multiple apps are port-searching at the same time.
stekou
reviewed
Apr 26, 2021
cgillum
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current RPC port selection logic favors ephemeral ports. This leads to
issues with the web apps sandbox.
Instead, we now use randomized port selection from an approved range of
ports.
Issue describing the changes in this PR
resolves #1798
Pull request checklist
pending_docs.mdrelease_notes.md