Fix custom backend provider logging on Linux #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a custom durability provider uses its ETW event source before we instantiate the Linux logging architecture (like Netherite's ETW event for instantiating its orchestration service), then the OnEventSourceCreated method will call before our constructor finishes instantiating the event source name for the custom provider. This happens due to the ordering of constructor calls in .NET. To work around this, we temporarily store all event sources before our constructor establishes the durability provider event source name so that we can enable the correct provider when we do establish the provider name.
ConnorMcMahon
commented
May 25, 2021
ConnorMcMahon
commented
May 25, 2021
|
|
||
| // Validate that the JSON has DurableTask-AzureStorage fields | ||
| string[] lines = consoleOutput.Split('\n'); | ||
| var azureStorageLogLines = lines.Where(l => l.Contains("DurableTask-CustomSource") && l.StartsWith(prefix)); |
There was a problem hiding this comment.
should change name of variable here.
There was a problem hiding this comment.
Thank you for this change! Seems like there are a few minor typos to address and I also left some comments.
Also, a question: Wouldn't it be possible to read the value for the durability provider from the app configuration itself inside of OnEventSourceCreated?
Say, would it be possible to read it as an environment variable when this.durabilityProviderEventSourceName is null?
I think that would be a cleaner approach.
added 2 commits
May 25, 2021 14:36
davidmrdavid
approved these changes
May 25, 2021
bachuv
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a custom durability provider uses its ETW event source before we
instantiate the Linux logging architecture (like Netherite's ETW event
for instantiating its orchestration service), then the
OnEventSourceCreated method will call before our constructor finishes
instantiating the event source name for the custom provider. This
happens due to the ordering of constructor calls in .NET.
To work around this, we temporarily store all event sources before our
constructor establishes the durability provider event source name so
that we can enable the correct provider when we do establish the provider name.
resolves #1796
Pull request checklist
pending_docs.mdrelease_notes.md