Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure function abort on shutdown #2456

Merged
merged 2 commits into from Apr 26, 2023
Merged

Ensure function abort on shutdown #2456

merged 2 commits into from Apr 26, 2023

Conversation

jviau
Copy link
Contributor

@jviau jviau commented Apr 25, 2023

Fixes an issue with gRPC out-of-proc durable workers where all in-flight activities and orchestrations would fail during host shutdown. The root issue is that the function invocation actually completes, but in a failed state, during host shutdown. The fix is to check for a combination of failure and host shutting down post invocation, then ensure we abort the session in this case.

resolves #2454

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation PR is ready to merge and referenced in pending_docs.md
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)
  • My changes do not require any extra work to be leveraged by OutOfProc SDKs
    • Otherwise: That work is being tracked here: #issue_or_pr_in_each_sdk
  • My changes do not change the version of the WebJobs.Extensions.DurableTask package
    • Otherwise: major or minor version updates are reflected in /src/Worker.Extensions.DurableTask/AssemblyInfo.cs
  • My changes do not add EventIds to our EventSource logs
    • Otherwise: Ensure the EventIds are within the supported range in our existing Windows infrastructure. You may validate this with a deployed app's telemetry. You may also extend the range by completing a PR such as this one.

Copy link
Contributor

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version rev looks good

@jviau jviau merged commit 30c1c9d into Azure:dev Apr 26, 2023
18 checks passed
@jviau jviau deleted the handle-drain branch April 26, 2023 18:31
jviau added a commit that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Durable function fails with TaskCanceledException and never gets retried
3 participants