client management apis(raise_event, createCheckStatusResponse) #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
February 6, 2020 15:16
…holder in url validation
shervyna
changed the title
shervyna
requested review from
scgbear and
priyaananthasankar
and removed request for
scgbear
scgbear
requested changes
Feb 13, 2020
|
|
||
| # tasks = [] |
There was a problem hiding this comment.
Can we remove the commented out code? Not a big fan of leaving that in the source code
There was a problem hiding this comment.
yeah sorry about that, I was planning to write this part after Createtimer is merged so that I can write a complete sample. but i think I dont have much time left in this project so maybe I will just put a simple sample here and remove the commented code
There was a problem hiding this comment.
Can you leave a TODO so that I can fill that up with createTimer?
added 8 commits
February 13, 2020 13:34
…zure-function to requirement.txt for pytest
scgbear
approved these changes
Feb 14, 2020
priyaananthasankar
approved these changes
Feb 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #44 , #48