Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "source" function metadata property #351

Closed
mathewc opened this issue May 13, 2016 · 2 comments
Closed

Rename "source" function metadata property #351

mathewc opened this issue May 13, 2016 · 2 comments
Assignees
@mathewc
Labels
breaking-change
Milestone
Current

Comments

@mathewc
Copy link
Member

mathewc commented May 13, 2016

This property allows people to indicate the entry script for a function, if the convention based resolution doesn't work for them.

Rather than "source", we should name this "script", "entry", or"primary". Should also make sure the property value can contain the file name w/o extension (I think extension is required currently).
@mathewc mathewc mentioned this issue May 13, 2016
Closed
@davidebbo
Copy link
Contributor

scriptFile would I think make it clearer that the value is referring to filename.

@davidebbo davidebbo added this to the Current milestone May 13, 2016
@davidebbo
Copy link
Contributor

Make sure Kudu is changed accordingly

@mathewc mathewc mentioned this issue May 14, 2016
Merged
mathewc added a commit that referenced this issue May 17, 2016
@mathewc
Rename Source metadata property, clean up resolution logic (#351)
c88773b
@mathewc mathewc closed this as completed Jun 20, 2016
maiqbal11 pushed a commit that referenced this issue Nov 1, 2019
@ahmelsayed
Use az-cli for login context
d776e40 
Closes #617
Closes #275
Closes #180
Closes #620
Closes #351
Closes #237
Closes #408
Closes #402
Closes #325
Closes #308
Closes #297
Closes #296
@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mathewc mathewc

Labels
breaking-change
Projects
None yet
Milestone
Current
Development

No branches or pull requests
3 participants
@davidebbo @mathewc @christopheranderson