Using SDK MethodInvoker rather than reflection for method invoke #6546
Conversation
|
|
||
| public ProxyEndToEndTests(TestFixture fixture) | ||
| { | ||
| _fixture = fixture; | ||
| _settingsManager = ScriptSettingsManager.Instance; | ||
| _hostName = new HostNameProvider(SystemEnvironment.Instance).Value ?? "localhost"; |
There was a problem hiding this comment.
Often on my machine I have a WEBSITE_SITE_NAME env var set which breaks these tests.
| @@ -267,7 +269,7 @@ protected override async Task<object> InvokeCore(object[] parameters, FunctionIn | |||
| int actualParameterCount = function.GetParameters().Length; | |||
| parameters = parameters.Take(actualParameterCount).ToArray(); | |||
|
|
|||
| object result = function.Invoke(null, parameters); | |||
| object result = await _methodInvoker.InvokeAsync(null, parameters); | |||
There was a problem hiding this comment.
Replacing reflection invoke with call to compiled lambda. We're now using the same MethodInvokerFactory that the core SDK uses when invoking methods.
| @@ -3,6 +3,7 @@ | |||
| <packageSources> | |||
| <add key="nuget.org" value="https://www.nuget.org/api/v2/" /> | |||
| <add key="azure_app_service" value="https://www.myget.org/F/azure-appservice/api/v2" /> | |||
| <add key="azure-appservice-test" value="https://azfunc.pkgs.visualstudio.com/e6a70c92-4128-439f-8012-382fe78d6396/_packaging/azure-appservice-test%40Local/nuget/v3/index.json" /> | |||
There was a problem hiding this comment.
Adding new test package source I created in devops for intermediate test packages. E.g. I've uploaded packages that contain new SDK APIs this PR relies on, which allows the PR build to pass, before those changes are actually published.
| @@ -64,7 +64,7 @@ | |||
| <PackageReference Include="Microsoft.Azure.Services.AppAuthentication" Version="1.0.3" /> | |||
| <PackageReference Include="Microsoft.Azure.Storage.File" Version="11.1.7" /> | |||
| <PackageReference Include="Microsoft.Azure.WebJobs.Host.Storage" Version="4.0.1" /> | |||
| <PackageReference Include="Microsoft.Azure.WebJobs" Version="3.0.20" /> | |||
| <PackageReference Include="Microsoft.Azure.WebJobs" Version="3.0.21-dev637336297117359276" /> | |||
There was a problem hiding this comment.
Temp - will update with actual package version
| // unwrap the task | ||
| if (result is Task) | ||
| { | ||
| result = await ((Task)result).ContinueWith(t => GetTaskResult(t), TaskContinuationOptions.ExecuteSynchronously); |
There was a problem hiding this comment.
No longer need to use reflection to unwrap the task result
|
I'll have to re-approve once you update the nugets. |
mathewc
force-pushed
the
method-invoker
branch
from
70e553b
to
4c0506b
Compare
No description provided.