V3 - add warning when customers registers HttpClient using DI #7674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettsam
reviewed
Sep 23, 2021
6 tasks
liliankasem
previously approved these changes
Sep 28, 2021
brettsam
reviewed
Sep 30, 2021
| webJobsBuilder.Services.TryAddSingleton<HttpClient>(f => | ||
| { | ||
| var loggerFactory = f.GetService<ILoggerFactory>(); | ||
| loggerFactory.CreateLogger("Host.Startup").LogWarning("Using HttpClient as an injected dependency will not be supported in future versions of Azure Functions. Use IHttpClientFactory instead. See http://aka.ms/functions-httpclient-di for more information."); |
There was a problem hiding this comment.
nit: can you use LogCategories.Startup constant instead?
liliankasem
reviewed
Oct 1, 2021
| - Updated Java Worker Version to [1.9.0](https://github.com/Azure/azure-functions-java-worker/releases/tag/1.9.0) | ||
|
|
||
|
|
There was a problem hiding this comment.
super nit: accidental extra line?
liliankasem
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves part of #7585. Still need to implement v4 breaking change.
Pull request checklist
release_notes.mdAdditional information
Non-breaking change for V3.