Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth handler gated on SecretsEnabled check. #8083

Merged
merged 1 commit into from Mar 25, 2022

Conversation

kashimiz
Copy link
Contributor

@kashimiz kashimiz commented Jan 20, 2022

Issue describing the changes in this PR

Addresses #5922.

Ported forward to #8239.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@kashimiz kashimiz changed the base branch from dev to v3.x January 20, 2022 20:42
@kashimiz kashimiz changed the title [DRAFT] Auth handler gated on SecretsEnabled check. Auth handler gated on SecretsEnabled check. Jan 21, 2022
@kashimiz kashimiz force-pushed the kashimiz/secretstoragetypenone-simple branch from 3a0222a to cb9bf2f Compare March 14, 2022 18:22
@kashimiz kashimiz force-pushed the kashimiz/secretstoragetypenone-simple branch from cb9bf2f to b7ab159 Compare March 14, 2022 20:19
@kashimiz kashimiz requested a review from mathewc March 15, 2022 21:54
@kashimiz kashimiz force-pushed the kashimiz/secretstoragetypenone-simple branch from d52aaca to 4930b5d Compare March 15, 2022 22:16
mathewc
mathewc previously approved these changes Mar 16, 2022
@mathewc
Copy link
Member

mathewc commented Mar 16, 2022

Need to port to v4 as well.

@kashimiz kashimiz merged commit 29cae32 into v3.x Mar 25, 2022
@kashimiz kashimiz deleted the kashimiz/secretstoragetypenone-simple branch March 25, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants