Removing binding direction from event name when emitting binding metric to logs. #8128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liliankasem
previously approved these changes
Feb 10, 2022
mathewc
reviewed
Feb 11, 2022
test/WebJobs.Script.Tests/Diagnostics/FunctionInstanceLoggerTests.cs
Outdated
Show resolved
Hide resolved
mathewc
reviewed
Feb 11, 2022
mathewc
previously approved these changes
Feb 11, 2022
mathewc
reviewed
Feb 11, 2022
mathewc
approved these changes
Feb 11, 2022
liliankasem
approved these changes
Feb 11, 2022
kshyju
added a commit
that referenced
this pull request
Mar 15, 2022
…ic to logs. (#8128) * Removing binding direction when emitting binding metric to logs. * Fixed test to address PR feedback. * Removing unused constant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, for in-proc function apps, only trigger bindings were included in the function meta data. So, no other bindings (out/return) are being logged to the functions metrics logs. This is being fixed with this PR: Include all bindings when generating function metadata
As part of fixing this issue, we have decided to remove the binding direction value ("in" or "out") from the event name when emitting this to the functions metrics logs since we cannot reliably get this value.