-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address F# Assembly Resolution Issues #893
Changes from all commits
159e37c
0d20f6b
5fbc7ff
a0b687e
2a7090f
f5e81d2
31e7b3c
d22c965
f5aeaf4
6e6a926
ad90d51
b1f21cb
785a86c
40053e2
05093fa
4395106
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,6 +27,12 @@ public async Task ServiceBusQueueTriggerToBlobTest() | |
await ServiceBusQueueTriggerToBlobTestImpl(); | ||
} | ||
|
||
[Fact] | ||
public async Task TwilioReferenceInvokeSucceeds() | ||
{ | ||
await TwilioReferenceInvokeSucceedsImpl(isDotNet: true); | ||
} | ||
|
||
//[Fact] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove commented out code |
||
//public async Task MobileTables() | ||
//{ | ||
|
@@ -172,6 +178,24 @@ public async Task SharedAssemblyDependenciesAreLoaded() | |
Assert.Equal("secondary type value", request.Properties["DependencyOutput"]); | ||
} | ||
|
||
//[Fact] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove commented out code |
||
//public async Task NugetChartingReferencesInvokeSucceeds() | ||
//{ | ||
// TestHelpers.ClearFunctionLogs("NugetChartingReferences"); | ||
|
||
// string testData = Guid.NewGuid().ToString(); | ||
// string inputName = "input"; | ||
// Dictionary<string, object> arguments = new Dictionary<string, object> | ||
// { | ||
// { inputName, testData } | ||
// }; | ||
// await Fixture.Host.CallAsync("NugetChartingReferences", arguments); | ||
|
||
// // make sure the input string made it all the way through | ||
// var logs = await TestHelpers.GetFunctionLogsAsync("NugetChartingReferences"); | ||
// Assert.True(logs.Any(p => p.Contains(testData))); | ||
//} | ||
|
||
[Fact] | ||
public async Task PrivateAssemblyDependenciesAreLoaded() | ||
{ | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ | ||
"bindings": [ | ||
{ | ||
"type": "manualTrigger", | ||
"name": "input", | ||
"direction": "in" | ||
} | ||
] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
#r "Twilio.Api" | ||
|
||
using System; | ||
using Microsoft.Azure.WebJobs.Host; | ||
using Twilio; | ||
|
||
public static void Run(string input, TraceWriter log) | ||
{ | ||
log.Info(input); | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
// This prelude allows scripts to be edited in Visual Studio or another F# editing environment | ||
|
||
#if !COMPILED | ||
#I "../../../../../bin/Binaries/WebJobs.Script.Host" | ||
#I "../../../../../src/WebJobs.Script.Host/bin/Debug" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you should just remove all of these !COMPILED blocks from all the sample/test functions. You don't have to block on this if you feel strongly, but I think it adds more confusion/bloat than it is worth. Furthermore, even with your update I don't get any intellisense - I think your paths are still wrong :) My vote is to just remove and keep the functions clean. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If kept, I believe we're going going too far up and the path should be |
||
#r "Microsoft.Azure.WebJobs.Host.dll" | ||
#r "Microsoft.Azure.WebJobs.Extensions.dll" | ||
#endif | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: update (or remove) the comment