Improve host.json sanitization #9459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liliankasem
approved these changes
Aug 11, 2023
fabiocav
approved these changes
Aug 14, 2023
|
/backport to v3.x |
|
Started backporting to v3.x: https://github.com/Azure/azure-functions-host/actions/runs/6554523233 |
|
@fabiocav backporting to v3.x failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Improve host.json sanitization
Applying: Sanitize based on property name as well
Applying: update release_notes.md
Using index info to reconstruct a base tree...
M release_notes.md
Falling back to patching base and 3-way merge...
Auto-merging release_notes.md
CONFLICT (content): Merge conflict in release_notes.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 update release_notes.md
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
jviau
added a commit
that referenced
this pull request
Oct 18, 2023
|
v3.x port: #9624 |
fabiocav
pushed a commit
that referenced
this pull request
Oct 19, 2023
* Improve host.json sanitization (#9459) * Contains -> IndexOf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves internal issue
Pull request checklist
release_notes.mdAdditional information
This PR improves redaction of host.json contents. Typically, the sections we allow-list in the log should not contain creds (no json file should have them really), but some could be mistakenly checked in there.