Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing noise for metadata logging #9464

Merged
merged 9 commits into from
Aug 21, 2023
Merged

Conversation

aishwaryabh
Copy link
Contributor

@aishwaryabh aishwaryabh commented Aug 14, 2023

Issue describing the changes in this PR

The host and worker metadata providers can be checked in parallel due to GetFunctionMetadata being called in the FunctionMetadataManager. After stepping through the code, I saw that the function gets called twice, once when we set includeCustomProviders to false and the second time when includeCustomProviders is set to true. We don't want to log how many functions have been loaded after we log how many have been found.

Here's how the logging looked like before:

[2023-07-25T23:22:43.607Z] Loading functions metadata
[2023-07-25T23:22:43.607Z] Reading functions metadata
[2023-07-25T23:22:43.626Z] 1 functions found
[2023-07-25T23:22:43.628Z] 0 functions loaded

And here is what the logging looks like now:

[2023-07-25T23:22:43.607Z] Loading functions metadata
[2023-07-25T23:22:43.607Z] Reading functions metadata (Custom)
[2023-07-25T23:22:43.626Z] Reading functions metadata (Custom)
[2023-07-25T23:22:43.628Z] 0 functions loaded

resolves #9420

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@aishwaryabh aishwaryabh requested a review from a team as a code owner August 14, 2023 20:19
@liliankasem
Copy link
Member

Don't forget to also update the change log!

@mathewc
Copy link
Member

mathewc commented Aug 14, 2023

I've been seeing these extraneous logs and have wondered where they were coming from. Good to clean this up since it's confusing during log investigations

@liliankasem liliankasem self-requested a review August 14, 2023 23:53
@aishwaryabh aishwaryabh merged commit 655b8a6 into dev Aug 21, 2023
10 checks passed
@aishwaryabh aishwaryabh deleted the aibhandari/metadata-logging-noise branch August 21, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Host and worker metadata providers can happen at the same time
3 participants