-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reducing noise for metadata logging #9464
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liliankasem
approved these changes
Aug 14, 2023
Don't forget to also update the change log! |
I've been seeing these extraneous logs and have wondered where they were coming from. Good to clean this up since it's confusing during log investigations |
mathewc
reviewed
Aug 14, 2023
mathewc
reviewed
Aug 15, 2023
mathewc
reviewed
Aug 17, 2023
mathewc
reviewed
Aug 17, 2023
mathewc
reviewed
Aug 17, 2023
mathewc
reviewed
Aug 17, 2023
mathewc
reviewed
Aug 17, 2023
mathewc
reviewed
Aug 17, 2023
mathewc
reviewed
Aug 17, 2023
mathewc
reviewed
Aug 17, 2023
mathewc
reviewed
Aug 17, 2023
mathewc
reviewed
Aug 17, 2023
mathewc
reviewed
Aug 17, 2023
mathewc
reviewed
Aug 21, 2023
mathewc
reviewed
Aug 21, 2023
mathewc
reviewed
Aug 21, 2023
mathewc
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
The host and worker metadata providers can be checked in parallel due to
GetFunctionMetadata
being called in theFunctionMetadataManager
. After stepping through the code, I saw that the function gets called twice, once when we setincludeCustomProviders
to false and the second time whenincludeCustomProviders
is set to true. We don't want to log how many functions have been loaded after we log how many have been found.Here's how the logging looked like before:
And here is what the logging looks like now:
resolves #9420
Pull request checklist
release_notes.md
Additional information
Additional PR information