Add diagnostic events for scenarios that prevent a function app from starting #9597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
balag0
reviewed
Oct 11, 2023
src/WebJobs.Script.WebHost/Management/LinuxSpecialization/RunFromPackageHandler.cs
Outdated
Show resolved
Hide resolved
fabiocav
reviewed
Oct 16, 2023
src/WebJobs.Script.WebHost/Management/LinuxSpecialization/RunFromPackageHandler.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script.WebHost/Security/KeyManagement/BlobStorageSecretsRepository.cs
Outdated
Show resolved
Hide resolved
Francisco-Gamino
requested review from
vrdmr,
pragnagopa,
eliaslopezgt,
VpOfEngineering,
gavin-aguiar,
YunchuWang and
pdthummar
as code owners
Francisco-Gamino
force-pushed
the
Francisco-Gamino/add-diagnostic-events
branch
2 times, most recently
from
cfb7ad4
to
7d400e6
Compare
soninaren
reviewed
Oct 31, 2023
src/WebJobs.Script.WebHost/Security/KeyManagement/BlobStorageSecretsRepository.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script.WebHost/Security/KeyManagement/SecretManager.cs
Outdated
Show resolved
Hide resolved
eliaslopezgt
reviewed
Nov 1, 2023
src/WebJobs.Script.WebHost/Security/KeyManagement/BlobStorageSecretsRepository.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script.WebHost/Security/KeyManagement/SecretManager.cs
Dismissed
Show resolved
Hide resolved
soninaren
approved these changes
Nov 1, 2023
aishwaryabh
approved these changes
Nov 3, 2023
src/WebJobs.Script.WebHost/Security/KeyManagement/BlobStorageSecretsRepository.cs
Outdated
Show resolved
Hide resolved
…on-decryptable secrets backups
…access tier is set to archived
Francisco-Gamino
force-pushed
the
Francisco-Gamino/add-diagnostic-events
branch
from
92c961b
to
8ff8fa9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
This PR resolve the following issues:
HostIdCollisionErrorCode should be AZFD0004 instead of AZFD004 #9214
Diagnostic event for when the function app has 10 non-decryptable secrets backups #9430. In this scenario, the Functions Host generates a diagnostic event when the app is unable to start due to the presence of 10 non-decryptable secrets backups. The event documentation will provide guidance to help the user delete the backups, as well as instructions on how to prevent the function app from reaching this state. The screenshot below shows the diagnostic event in the Portal.
RequestFailedException,Status409, andError codeBlobArchived, the event is triggered./cc @eamonoreilly @mattchenderson @fabiocav
Pull request checklist
release_notes.mdAdditional information
Additional PR information