Performance improvements for file logging #9655
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making some performance improvements to file logging based on a recent CRI investigation. In that investigation, we were seeing thread exhaustion in the host process with many threads blocked on file IO. When the issue occurred, the app had FileLoggingMode enabled (see doc for fileLoggingMode) because they had the portal open on the app. This causes the log stream to also go to files. At the time the app was under high load, so there was a lot of file logging happening. Compounding things was the fact that the customer was also logging errors, triggering our "force flush on error" logic.
Pull request checklist
release_notes.md