Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving worker shutdown test to prevent regressions #9743

Merged
merged 1 commit into from Dec 14, 2023

Conversation

brettsam
Copy link
Member

@brettsam brettsam commented Dec 14, 2023

Test-only change.

In #9738, I fixed a race condition on worker shutdown. However, the test I wrote was very hard to use as a repro and thus was not a great regression test. I've since found a better way to time the multiple threads.

Currently submitting this back when the bug existed to ensure it would have caught the regression.
Edit: This is now ready.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@brettsam brettsam requested a review from a team as a code owner December 14, 2023 16:57
@brettsam
Copy link
Member Author

/azp run

Copy link

Pull request contains merge conflicts.

@brettsam brettsam force-pushed the brettsam/worker_shutdown_test branch from 3d6387c to 7228f38 Compare December 14, 2023 17:06
@brettsam brettsam force-pushed the brettsam/worker_shutdown_test branch from 7228f38 to 5ce3e29 Compare December 14, 2023 18:17
@brettsam
Copy link
Member Author

For one of the steps here I reverted the fix and let the test run to ensure we would have caught it.

Proof that the test failed in CI before the fix was applied: https://azfunc.visualstudio.com/Azure%20Functions/_build/results?buildId=158816&view=ms.vss-test-web.build-test-results-tab&runId=1371853&resultId=101182&paneView=debug

@brettsam brettsam merged commit 0771ce5 into dev Dec 14, 2023
9 checks passed
@brettsam brettsam deleted the brettsam/worker_shutdown_test branch December 14, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants