Improving worker shutdown test to prevent regressions #9743
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test-only change.
In #9738, I fixed a race condition on worker shutdown. However, the test I wrote was very hard to use as a repro and thus was not a great regression test. I've since found a better way to time the multiple threads.
Currently submitting this back when the bug existed to ensure it would have caught the regression.Edit: This is now ready.
Pull request checklist
release_notes.md