Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging Settings for host split #9747

Merged
merged 8 commits into from Jan 8, 2024
Merged

Logging Settings for host split #9747

merged 8 commits into from Jan 8, 2024

Conversation

aishwaryabh
Copy link
Contributor

@aishwaryabh aishwaryabh commented Dec 19, 2023 •
edited

Issue describing the changes in this PR

resolves #9721

This PR logs the properties that will be useful to have for the host split project. Here is an example logging:
image

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@aishwaryabh aishwaryabh requested a review from a team as a code owner December 19, 2023 18:45
kshyju
kshyju approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@kshyju kshyju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description can be updated to reflect the new keyname (for currentDirectory)

@aishwaryabh aishwaryabh merged commit 87ec218 into dev Jan 8, 2024
9 checks passed
@aishwaryabh aishwaryabh deleted the aibhandari/logging-host-split branch January 8, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kshyju kshyju kshyju approved these changes

@brettsam brettsam brettsam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Host Split: explicitly log settings and root path
3 participants
@aishwaryabh @kshyju @brettsam