Use auth to decrypt signature and use container name for audience #9775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathewc
reviewed
Jan 9, 2024
src/WebJobs.Script.WebHost/Security/Authentication/Jwt/ScriptJwtBearerExtensions.cs
Outdated
Show resolved
Hide resolved
added 2 commits
January 9, 2024 13:48
|
The description of this PR should be updated so it describes the actual change being made. Also, it doesn't seem you're linking to the actual changes you're backporting from. I think you're trying to backport a portion of #9348? |
Tonewall
changed the title
Updated the PR name and linked the PRs backporting from |
mathewc
reviewed
Jan 10, 2024
src/WebJobs.Script.WebHost/Security/Authentication/Jwt/ScriptJwtBearerExtensions.cs
Show resolved
Hide resolved
fabiocav
requested changes
Jan 10, 2024
mathewc
previously approved these changes
Jan 10, 2024
Filled out the PR description with the changes in the PR |
|
@fabiocav could you have another look? |
Tonewall
force-pushed
the
u/tonychoi/v3.x-backport
branch
from
e6a99f0
to
fc046a2
Compare
fabiocav
approved these changes
Jan 11, 2024
mathewc
approved these changes
Jan 11, 2024
VpOfEngineering
pushed a commit
that referenced
this pull request
Jan 11, 2024
) * Update valid audience for legion applications during specialization * Update valid audience for legion applications during specialization P2 * fix inden * Use auth to decrypt signature * missed commit * Adding logger and audience/issuer validator back * fixing indentation * Revert indentation * Unit test to validate audience --------- Co-authored-by: Tony Choi <tonychoi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting parts of #9325 and #9348
Issue describing the changes in this PR
Uses Container name as the valid audience for placeholders in Linux Consumption because sitename are not present when in placeholder mode. This PR also includes changes to accept signature as part of the token for container assignment.
Pull request checklist
release_notes.md