-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function group to metadata and sync triggers #9777
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liliankasem
approved these changes
Jan 8, 2024
liliankasem
reviewed
Jan 9, 2024
mathewc
approved these changes
Jan 10, 2024
jviau
added a commit
that referenced
this pull request
Jan 11, 2024
* Add function group to metadata and sync triggers * update release_notes.md * Fix csproj changes, check for webhook, only add grouping for flex * Add IsWebHookTrigger tests * Fix test build * fix tests
jviau
added a commit
that referenced
this pull request
Jan 11, 2024
jviau
added a commit
that referenced
this pull request
Jan 29, 2024
* Add function group to metadata and sync triggers * update release_notes.md * Fix csproj changes, check for webhook, only add grouping for flex * Add IsWebHookTrigger tests * Fix test build * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #9732
Pull request checklist
release_notes.md
Additional information
This PR adds function grouping calculation as an extension method
FunctionMetadata.GetFunctonGroup()
. Function grouping is included in sync-triggers payload if it is non-null. Function grouping calculation works as follows:FunctionMetadata.Properties["FunctionGroup"]
is present, return that.http
ordurable
respectively.null
if none of the above checks succeed.Some additional changes include binding & function metadata extensions refactoring.