Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function group to metadata and sync triggers #9777

Merged
merged 7 commits into from
Jan 10, 2024
Merged

Conversation

jviau
Copy link
Contributor

@jviau jviau commented Jan 8, 2024

Issue describing the changes in this PR

resolves #9732

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

This PR adds function grouping calculation as an extension method FunctionMetadata.GetFunctonGroup(). Function grouping is included in sync-triggers payload if it is non-null. Function grouping calculation works as follows:

  1. If FunctionMetadata.Properties["FunctionGroup"] is present, return that.
  2. Else, check if HTTP or Durable trigger. Return http or durable respectively.
  3. Return null if none of the above checks succeed.

Some additional changes include binding & function metadata extensions refactoring.

@jviau jviau requested a review from a team as a code owner January 8, 2024 21:58
@jviau jviau merged commit 171e5b1 into dev Jan 10, 2024
9 checks passed
@jviau jviau deleted the jviau/func-group branch January 10, 2024 19:29
@jviau jviau restored the jviau/func-group branch January 10, 2024 19:37
@jviau jviau deleted the jviau/func-group branch January 10, 2024 20:54
@jviau jviau restored the jviau/func-group branch January 10, 2024 23:58
jviau added a commit that referenced this pull request Jan 11, 2024
jviau added a commit that referenced this pull request Jan 11, 2024
* Add function group to metadata and sync triggers

* update release_notes.md

* Fix csproj changes, check for webhook, only add grouping for flex

* Add IsWebHookTrigger tests

* Fix test build

* fix tests
jviau added a commit that referenced this pull request Jan 11, 2024
* Add function group to metadata and sync triggers

* update release_notes.md

* Fix csproj changes, check for webhook, only add grouping for flex

* Add IsWebHookTrigger tests

* Fix test build

* fix tests
jviau added a commit that referenced this pull request Jan 29, 2024
* Add function group to metadata and sync triggers

* update release_notes.md

* Fix csproj changes, check for webhook, only add grouping for flex

* Add IsWebHookTrigger tests

* Fix test build

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flex][Scaling] Add function grouping information
3 participants