Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PUT to the list of supported WebHook verbs #9812

Merged
merged 1 commit into from Jan 20, 2024
Merged

Adding PUT to the list of supported WebHook verbs #9812

merged 1 commit into from Jan 20, 2024

Conversation

mathewc
Copy link
Member

@mathewc mathewc commented Jan 17, 2024

I think this was just an oversight - no reason we can't let extension WebHook handlers support PUT as well. The ask is coming from @apranaseth for Workflow scenarios.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@mathewc mathewc requested a review from a team as a code owner January 17, 2024 20:00
@mathewc mathewc requested a review from fabiocav January 17, 2024 20:01
@mathewc mathewc merged commit d0f3ea8 into dev Jan 20, 2024
9 checks passed
@mathewc mathewc deleted the webhook-put branch January 20, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants